refactor(gossipsub/rpc): inline _decode_varint_at wrapper#739
Merged
tcoratger merged 1 commit intoMay 21, 2026
Conversation
The wrapper only converted the canonical "(value, bytes_consumed)" return shape into "(value, new_position)" by adding pos. Every other consumer of decode_varint in the codebase already uses the canonical "(value, consumed); pos += consumed" pattern, so removing the wrapper aligns this module with the rest. Net six lines smaller; no behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_decode_varint_atwrapper ingossipsub/rpc.py. It only converted the canonical(value, bytes_consumed)return into(value, new_position)by addingpos.value, consumed = decode_varint(data, pos); pos += consumedpattern, matching every otherdecode_varintconsumer in the codebase (snappy, reqresp, transport/quic, behavior, event_source/gossip).Test plan
uv run pytest tests/lean_spec/subspecs/networking/gossipsub/— 173 tests pass.grep _decode_varint_atacrosssrc/,tests/,packages/— no remaining references.🤖 Generated with Claude Code